Add DateOnlyCellValue and TimeOnlyCellValue#1119
Merged
Merged
Conversation
lahma
reviewed
Jul 22, 2023
Collaborator
lahma
left a comment
lahma
left a comment
There was a problem hiding this comment.
Added some feedback to reduce copy-pasting. Also most importantly - the tests fail. It makes no sense to have the tests suite running and helping against regressions if PRs which are not green get merged...
| public DateOnly? DateOnlyCellValue | ||
| { | ||
| get{ | ||
| if (CellType == CellType.Blank||CellType == CellType.String||CellType == CellType.Boolean||CellType == CellType.Error) |
Collaborator
There was a problem hiding this comment.
seems that this code gets repeated a log and only this different is the last like, whether to get DateOnly or TimeOnly, maybe could extract helper for the beginning part?
| } | ||
| double value = NumericCellValue; | ||
| bool date1904 = Sheet.Workbook.IsDate1904(); | ||
| return DateOnly.FromDateTime(DateUtil.GetJavaDate(value, date1904)); |
Collaborator
There was a problem hiding this comment.
repetition again, could it just be:
var dateTime = DateUtil.FromCellValue(this);
return DateOnly.FromDateTime(DateUtil.GetJavaDate(value, date1904));
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.