Reduce string allocations when writing documents#1095
Merged
Conversation
ac0334d to
29fea12
Compare
Member
|
LGTM |
Member
|
I'm checking if we can rewrite serialization part with https://github.com/Cysharp/ZString. According to nuget stats, this library looks popular. I found this library via this post |
Collaborator
Author
|
I can recommend that library, Orchard Core for example uses that, got a PR approved once to that lib Cysharp/ZString#50 . |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string.Formatis a bad thing in hot paths. Changed code to call multipleWrites instead of string concatenation.NPOI.Benchmarks.LargeExcelFileBenchmark
NPOI.Benchmarks.RangeValuesBenchmark