fix EmbeddedResource access on net472#1083
Merged
Merged
Conversation
In runtime, properly load following three embedded resources on net472. - `functionMetadata.txt` and `font_metrics.properties` in NPOI project - `presetTableStyles.xml` in NPOI.OOXML project
Member
|
LGTM |
Contributor
Author
|
Thanks! |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three embedded resouces in NPOI.
functionMetadata.txtandfont_metrics.propertiesin NPOI projectpresetTableStyles.xmlin NPOI.OOXML projectIn previous, thee resource files on net472 has inconsistent settings against NET Core.
NPOI.csproj:
The two files had shorthand
LogicalNames.NPOI.OOXML.csproj:
presetTableStyles.xmlhad been properly regeistered in NPOI.OOXML.Core.csproj, but not in NPOI.OOXML.csproj as EmbeddedResource, so it had been already broken in net472.After we migrate SDK style csproj in #1037, the default LogicalName which has assembly name + relative path in project is given to each embedded resourecs. But, the shorthand names were still used for net472 by conditional compilation, so the runtime resource loading has been failing.
This fix will significantly increase passed test numbers in net472.
net6.0: (nothing changed)
net472 (before):
net472 (after):