Fix exception thrown when reading file with closing </br> tag in drawing.vml#1081
Merged
tonyqus merged 2 commits intoMay 14, 2023
Conversation
added 2 commits
May 12, 2023 15:44
… an opening and closing br tags
…ng and closing br tags
Member
|
Looks this change is safe. LGTM |
artemkoloskov-admin
deleted the
upstream-fix-closing-br-tag-in-xssfvmldrawing
branch
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSSFVMLDrawing.Read method would remove the opening br tag, and normally it will be enough, because normally a br tag doesn't need closing tag. But sometimes it has one, so it needs to be removed also.
The pull request also adds a test for the issue.