Fix Drawing shape#1080
Merged
Merged
Conversation
Member
|
This change may break drawing.xml. Do you have any unit test or sample that I can take a look to make sure your code is really working. |
Contributor
Author
|
I am here. |
Contributor
Author
|
slightly more complicated example |
Contributor
Author
|
The test just read and write as below |
fix shape id numbering
Contributor
Author
|
I added the shape's properties ID,Name |
Member
|
Is this PR still in progress? I see a few changes during the past days. If so, please put WIP prefix in the title. |
Contributor
Author
|
This concludes the functionality I want to add. thank you |
Contributor
Author
|
In my environment (fork branch) I don't get such test errors. . . . What should I do? |
Member
|
LGTM |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I made some read/write fixes and additions to drawing
please merge if you like
by google translate