Skip to content

Skip WINDOW2 validation when reading possibly non-compliant XLS #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 1 commit into from
Apr 12, 2023
Merged

Skip WINDOW2 validation when reading possibly non-compliant XLS #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions main/HSSF/Model/RecordOrderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,9 @@ public static bool IsEndOfRowBlock(int sid)
case DVALRecord.sid:
return true;
case EOFRecord.sid:
// WINDOW2 should always be present, so shouldn't have got this far
throw new InvalidOperationException("Found EOFRecord before WindowTwoRecord was encountered");
// WINDOW2 should always be present, but there can be files that are non-compliant to spec
// which are automatically fixed when saved again using Excel, so ignoring the problem when reading
return true;
}
return PageSettingsBlock.IsComponentRecord(sid);
}
Expand Down