Skip to content

Remove unused exception captures #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 1 commit into from
Mar 4, 2023
Merged

Remove unused exception captures #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main/SS/Formula/Functions/DateValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public override ValueEval Evaluate(int srcRowIndex, int srcColumnIndex, ValueEva
}
}
}
catch (FormatException e)
catch (FormatException)
{
return ErrorEval.VALUE_INVALID;
}
Expand All @@ -92,7 +92,7 @@ private int parseMonth(String monthPart)
{
return int.Parse(monthPart);
}
catch (FormatException ignored)
catch (FormatException)
{
}

Expand Down
2 changes: 1 addition & 1 deletion main/SS/Formula/Functions/Indirect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ private static ValueEval EvaluateIndirect(OperationEvaluationContext ec, String
{
areaPtg = FormulaParser.ParseStructuredReference(refText, (IFormulaParsingWorkbook)ec.GetWorkbook(), ec.RowIndex);
}
catch (FormulaParseException e)
catch (FormulaParseException)
{
return ErrorEval.REF_INVALID;
}
Expand Down
2 changes: 1 addition & 1 deletion ooxml/POIXMLDocumentPart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ protected RelationPart CreateRelationship(POIXMLRelation descriptor, POIXMLFacto
}
return new RelationPart(rel, doc);
}
catch (PartAlreadyExistsException pae)
catch (PartAlreadyExistsException)
{
// Return the specific exception so the user knows
// that the name is already taken
Expand Down