Skip to content

Exception cleanup#1034

Merged
tonyqus merged 3 commits into
nissl-lab:masterfrom
mycroes:exception-cleanup
Feb 28, 2023
Merged

Exception cleanup#1034
tonyqus merged 3 commits into
nissl-lab:masterfrom
mycroes:exception-cleanup

Conversation

@mycroes
Copy link
Copy Markdown
Contributor

@mycroes mycroes commented Feb 27, 2023

Change following exception behavior:

  1. Remove Exception rethrows (CA2200 violations)
  2. Remove redundant handling of IOException
  3. Replace Exception catch without capture with untyped catch clause

Michael Croes added 3 commits February 27, 2023 21:55
Also remove redundant try-catches (catching and rethrowing only).
Identical handling on Exception is right below.
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Feb 28, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants