Skip to content

Commit

Permalink
update ci workflows to fix staticcheck build
Browse files Browse the repository at this point in the history
  • Loading branch information
nishanths committed Mar 24, 2023
1 parent 23e1189 commit 4b98b67
Showing 1 changed file with 17 additions and 7 deletions.
24 changes: 17 additions & 7 deletions .github/workflows/all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
all:
strategy:
matrix:
go-version: [1.14, 1.16, 1.18, 1.x]
go-version: [1.14, 1.16, 1.19, 1.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}

Expand All @@ -20,14 +20,24 @@ jobs:
- name: build
run: make build

# for earlier go versions, staticcheck build fails due to
# ../../../go/pkg/mod/honnef.co/go/[email protected]/go/ir/builder.go:36:2: //go:build comment without // +build comment
- name: install vet tools (go1.17 or later)
if: ${{ matrix.go-version >= '1.17' }}
# for earlier go versions, staticcheck build fails due to:
#
# ../../../go/pkg/mod/honnef.co/go/[email protected]/go/ir/builder.go:36:2:
# //go:build comment without // +build comment
#
# or due to:
#
# ../../../go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4030:36:
# sel.Obj().(*types.Func).Origin undefined (type *types.Func has no field
# or method Origin)
# note: module requires Go 1.19
#
- name: install vet tools (go1.19 or later)
if: ${{ matrix.go-version >= '1.19' }}
run: make install-vet

- name: vet (go1.17 or later)
if: ${{ matrix.go-version >= '1.17' }}
- name: vet (go1.19 or later)
if: ${{ matrix.go-version >= '1.19' }}
run: make vet

- name: test
Expand Down

0 comments on commit 4b98b67

Please sign in to comment.