nirvlife structure round 2 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Chore(deps): validate react-fullerpage, fix eslint and add prettier * validate react-idealer-image * finalize react-idealer-image * Feat(dev): fake file watching the react app
noahehall
commented
Jun 10, 2023
| @@ -1,6 +1,8 @@ | |||
| import type { FC } from "react"; | |||
|
|
|||
| import IdealImage from "react-ideal-image"; | |||
| import { IdealImage } from "react-idealer-image"; | |||
| // import { IdealImage } from "../../../node_modules/react-ideal-image/src"; | |||
noahehall
commented
Jun 10, 2023
| @@ -1,3 +1,3 @@ | |||
| export default { | |||
| module.exports = { | |||
| extends: "../../.eslintrc.cjs", | |||
There was a problem hiding this comment.
extract this to an eslint package
noahehall
commented
Jun 10, 2023
| @@ -0,0 +1,21 @@ | |||
| import * as path from "path"; | |||
There was a problem hiding this comment.
put this file back into the devServer file
noahehall
commented
Jun 10, 2023
| const { outputs, success, logs, ...buildData } = await buildApp(); | ||
|
|
||
| console.info(`built success ${success}: total files`, outputs.length); | ||
| // generally we want to figure out how to serve assets |
There was a problem hiding this comment.
this comment shouldnt be needed anymore
noahehall
commented
Jun 10, 2023
| @@ -0,0 +1,21 @@ | |||
| // @see https://github.com/kentcdodds/kcd-scripts/blob/main/src/config/prettierrc.js | |||
There was a problem hiding this comment.
move this to a prettier package
and use the one we created for nodeproto
noahehall
commented
Jun 10, 2023
| import { ReactFP, FPContainer, FPItem } from "react-fullerpage"; | ||
| // <img src={"/img/logo_main.png"} className="img" alt="nirvai" /> | ||
| // import { ReactFP, FPContainer, FPItem } from "react-fullerpage"; | ||
| import { |
There was a problem hiding this comment.
use the main package as we can now develop with react-cosmos and dont need to copypaste into node_modules
also check on the bun issue with bun link not working
noahehall
commented
Jun 10, 2023
| @@ -1,4 +1,14 @@ | |||
| declare module "*.(svg|jpg|png)" { | |||
There was a problem hiding this comment.
dunno why this doenst fkn work
noahehall
commented
Jun 10, 2023
| @@ -1,7 +1,7 @@ | |||
| import { reportWebVitals } from "reportWebVitals"; | |||
| import React, { StrictMode } from "react"; | |||
| import ReactDOM, { createRoot } from "react-dom/client"; | |||
|
|
|||
| console.info("lol"); | |||
noahehall
commented
Jun 10, 2023
| @@ -3,6 +3,9 @@ | |||
| // ^ pretty sure this is just a copypasta from nirv | |||
There was a problem hiding this comment.
delete this file, turbo doesnt work with bun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C
T
A
push to next pr