Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method descriptions missing from Sounds Modules #44

Open
Zorba256 opened this issue May 2, 2024 · 4 comments
Open

Method descriptions missing from Sounds Modules #44

Zorba256 opened this issue May 2, 2024 · 4 comments

Comments

@Zorba256
Copy link

Zorba256 commented May 2, 2024

I'm starting to get interested in exploring audio in Python and was excited to discover the capabilities of your Jupylet project.

But I've just realized that although the documentation is extensive, many of the classes in the Sound and related modules only have the attributes defined, not the methods. Is this an oversight, or because they are waiting updating for the latest code changes or just because you have not got around to documenting them yet?

I note that the code itself is quite well documented, so perhaps there is an issue with documentation not getting automatically generated from the docstrings correctly?

I know that I can find out basic information about the classes using the Python "help" function but this does give any explanation of the methods, just the bare bones of class definitions.

Anyway, you're the expert and I'm only guessing but if you would like help in this area, then I've got the time (if only limited expertise) so I could have a go at helping with documentation.

@nir
Copy link
Owner

nir commented May 3, 2024

If the code is documented but these docstrings do not appear in the online documentation it could indeed indicate a problem in the documentation setup. if you are willing to look into that that would be awesome.

@Zorba256
Copy link
Author

Zorba256 commented May 4, 2024 via email

@Zorba256
Copy link
Author

I've now created a full set of docsstrings for all classes and methods in the /jupylet/audio/sound.py file with help of Chat GPT and then pasted them in by hand to the souce code. No python code was pasted back in from Chat GPT, so the original code should be preserved as it was unless I made a typo in editing.

Generally I've preserved the content of original docstrings where they existed and incorporated original single line comments within new docstrings.

I'm not experienced at setting up GitHub so that I can insert/update code, so I'm attaching the result as a file attachment here - but this has to be done as a .txt file so I've just changed the extension.

Jupylet Sound - Docstrings.txt

Please do refer any problems back to me.

@nir
Copy link
Owner

nir commented May 10, 2024

I think you need to create a pull request, but I'm not familiar with the procedure either. why don't you ask chatgpt how to do it and this way your contribution will be properly recorded ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants