Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented "with-timeout" plugin for testing the startup phase of lo… #732

Closed
wants to merge 1 commit into from

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Feb 24, 2024

…ng-running shell-command tasks

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

This PR adds a new worker to be used solely for testing of interfaces (in particularly the auto-converted interfaces from nipype). Given it is to be used purely for test purposes, it isn't ideal to have to add it in globally into the WORKERS dict but there doesn't seem a way to "bring your own" worker. Perhaps this would be better

Checklist

  • [ x ] I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@tclose tclose requested a review from djarecka February 24, 2024 12:45
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (1720ba6) to head (4d59aca).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   83.35%   83.36%   +0.01%     
==========================================
  Files          24       24              
  Lines        4949     4964      +15     
  Branches     1411     1411              
==========================================
+ Hits         4125     4138      +13     
- Misses        816      818       +2     
  Partials        8        8              
Flag Coverage Δ
unittests 83.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose
Copy link
Contributor Author

tclose commented Feb 25, 2024

Closing in favour of BYO approach in #733

@tclose tclose closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant