Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OAR Scheduler #713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ychiat35
Copy link

@ychiat35 ychiat35 commented Oct 16, 2023

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

The Oar scheduler is widely used in France, including mesocentre supercomputers (e.g., GRICAD), INRIA supercomputers, Grid5000 testbed and other platforms.

This PR adds support for the OAR Scheduler, following the implementation made for Slurm.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (0e3d33c) 83.52% compared to head (e54491c) 81.86%.

❗ Current head e54491c differs from pull request most recent head 3cadef2. Consider uploading reports for the commit 3cadef2 to get more accurate results

Files Patch % Lines
pydra/engine/workers.py 7.20% 103 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   83.52%   81.86%   -1.67%     
==========================================
  Files          23       23              
  Lines        4990     5101     +111     
  Branches     1429     1453      +24     
==========================================
+ Hits         4168     4176       +8     
- Misses        814      917     +103     
  Partials        8        8              
Flag Coverage Δ
unittests 81.86% <7.20%> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka
Copy link
Collaborator

djarecka commented Nov 3, 2023

@ychiat35 - thank you for adding this worker. Would it be possible to test it within a container?

@ychiat35 ychiat35 force-pushed the feature/oar branch 9 times, most recently from ea8a805 to f7d9e79 Compare November 14, 2023 16:23
@ychiat35 ychiat35 force-pushed the feature/oar branch 3 times, most recently from 6856bfb to e54491c Compare November 21, 2023 16:07
@ychiat35
Copy link
Author

@ychiat35 - thank you for adding this worker. Would it be possible to test it within a container?

Hi, I'm trying to use oar-docker to do that. It is still WIP (I have to find more time doing that) but I noticed that the oar-docker solution requires cgroup v1, so I have to run on ubuntu-20.04 but not ubuntu-latest. Is this a problem for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants