Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DaskWorker performance for all tests #708

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

adi611
Copy link
Contributor

@adi611 adi611 commented Sep 21, 2023

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Check DaskWorker performance for all tests

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 86.20% and project coverage change: -4.19% ⚠️

Comparison is base (0245cdc) 83.42% compared to head (c4691c5) 79.23%.
Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   83.42%   79.23%   -4.19%     
==========================================
  Files          22       23       +1     
  Lines        4894     4971      +77     
  Branches     1410     1424      +14     
==========================================
- Hits         4083     3939     -144     
- Misses        807      827      +20     
- Partials        4      205     +201     
Flag Coverage Δ
unittests 79.07% <83.90%> (-4.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pydra/conftest.py 53.12% <66.66%> (-24.66%) ⬇️
pydra/engine/run_pickled.py 76.19% <76.19%> (ø)
pydra/engine/workers.py 30.46% <91.66%> (+7.73%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka
Copy link
Collaborator

@adi611 - could you please resolve comflict in the conftest.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants