Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit false output templates #693

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Aug 31, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Optional output fields with output_file_template metadata (i.e. of type=ty.Union[Path, bool]) were getting printed to the command line regardless of whether a value for the field was set to False.

Checklist

  • I have added tests to cover my changes (if necessary)

@tclose tclose requested a review from djarecka August 31, 2023 02:56
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.50% ⚠️

Comparison is base (91c5a15) 83.23% compared to head (4d10b57) 82.73%.

❗ Current head 4d10b57 differs from pull request most recent head 62e3944. Consider uploading reports for the commit 62e3944 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   83.23%   82.73%   -0.50%     
==========================================
  Files          22       22              
  Lines        4848     4849       +1     
  Branches     1392        0    -1392     
==========================================
- Hits         4035     4012      -23     
- Misses        809      837      +28     
+ Partials        4        0       -4     
Flag Coverage Δ
unittests 82.73% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pydra/engine/helpers_file.py 91.80% <ø> (-0.55%) ⬇️
pydra/engine/helpers.py 86.35% <100.00%> (-0.25%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good. Q about logic.

pydra/engine/helpers_file.py Show resolved Hide resolved
@effigies effigies merged commit 62e3944 into nipype:master Sep 7, 2023
46 of 56 checks passed
@tclose tclose deleted the omit-false-output-templates branch September 11, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants