Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for dask #689

Closed

Conversation

djarecka
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

adi611 and others added 5 commits August 10, 2023 23:12
YAML gotcha 3.10 -> 3.1, versions should be quoted.
- Add concurrency group
- Add permissions
- Bump actions/setup-python to v4
- Add OS (Ubuntu and macOS) to test matrix
- Streamline job steps for testing
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.10% ⚠️

Comparison is base (29d3d1f) 82.88% compared to head (c7384b9) 78.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   82.88%   78.79%   -4.10%     
==========================================
  Files          22       22              
  Lines        4845     4848       +3     
  Branches     1391     1392       +1     
==========================================
- Hits         4016     3820     -196     
+ Misses        825      823       -2     
- Partials        4      205     +201     
Flag Coverage Δ
unittests 78.65% <100.00%> (-4.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pydra/engine/workers.py 22.73% <100.00%> (+3.45%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka
Copy link
Collaborator Author

my changes were already merged to #686 so closing this

@djarecka djarecka closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants