Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slurm container image in GitHub Actions workflow #688

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

adi611
Copy link
Contributor

@adi611 adi611 commented Aug 18, 2023

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Update the Slurm container image in testslurm.yml workflow to giovtorres/docker-centos7-slurm:latest which uses Slurm version 21.08.0.
GitHub: link; Docker Hub: link.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.48% ⚠️

Comparison is base (f796a9c) 83.23% compared to head (93782de) 82.75%.

❗ Current head 93782de differs from pull request most recent head 3f85037. Consider uploading reports for the commit 3f85037 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   83.23%   82.75%   -0.48%     
==========================================
  Files          22       22              
  Lines        4848     4848              
  Branches     1392        0    -1392     
==========================================
- Hits         4035     4012      -23     
- Misses        809      836      +27     
+ Partials        4        0       -4     
Flag Coverage Δ
unittests 82.75% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka
Copy link
Collaborator

@adi611 - can you check what version of pyld is installed within the container?

And perhaps you can check if you can run

from pyld import jsonld
jsonld.get_document_loader()

@djarecka
Copy link
Collaborator

it looks like jsonld.get_document_loader() returns a dummy loader and there are issues with setting jsonld.requests_document_loader due to older version of OpenSSL. You can try to update OpenSSL in the container, but it would be also fine to disable these four tests in this pytest run (the tests are not related to the slurm worker anyway)

@djarecka
Copy link
Collaborator

could you please resolve the conflict

@adi611
Copy link
Contributor Author

adi611 commented Aug 24, 2023

could you please resolve the conflict

Yes I'm working on it.

@adi611
Copy link
Contributor Author

adi611 commented Aug 24, 2023

For the Slurm GA workflow, the Run pytest part in running perfectly after excluding the 5 tests, but the Upload to codecov part throws an error: ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'OpenSSL 1.0.2k-fips 26 Jan 2017'.

@adi611
Copy link
Contributor Author

adi611 commented Aug 25, 2023

@djarecka - could you please re-run the Slurm workflow?

@adi611
Copy link
Contributor Author

adi611 commented Aug 25, 2023

The Slurm workflow seems to be working fine now, please let me know if further changes are required.

@djarecka djarecka merged commit 91c5a15 into nipype:master Aug 28, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants