Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nest_asyncio to install requires #501

Merged
merged 2 commits into from
May 30, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Oct 4, 2021

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Adds nest-asyncio dependency to setup.cfg

Checklist

N/A

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (e52e32b) to head (23755a5).
Report is 2 commits behind head on master.

Current head 23755a5 differs from pull request most recent head 0387d9c

Please upload reports for the commit 0387d9c to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   84.27%   84.22%   -0.06%     
==========================================
  Files          26       25       -1     
  Lines        5127     5123       -4     
  Branches     1447     1449       +2     
==========================================
- Hits         4321     4315       -6     
- Misses        800      802       +2     
  Partials        6        6              
Flag Coverage Δ
unittests 84.22% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djarecka
Copy link
Collaborator

since this is required only for working with jupyter notebook, I would not add it to the basic requirements. However, we could perhaps add additional mode of installation "jupyter". Or checking if pydra is run inside the jupyter notebook and raise an error if nest_asyncio is not detected.
What do you think?

@tclose
Copy link
Contributor Author

tclose commented Oct 17, 2021

since this is required only for working with jupyter notebook, I would not add it to the basic requirements. However, we could perhaps add additional mode of installation "jupyter". Or checking if pydra is run inside the jupyter notebook and raise an error if nest_asyncio is not detected. What do you think?

Sounds good

@tclose
Copy link
Contributor Author

tclose commented Mar 2, 2024

added "jupyter" install option to pyproject.toml as suggested

@tclose tclose requested a review from djarecka May 28, 2024 06:06
@tclose tclose added enhancement New feature or request bug Something isn't working patch Increment the patch version when merged (label from auto) and removed enhancement New feature or request labels May 28, 2024
@effigies effigies merged commit f5f9de9 into nipype:master May 30, 2024
41 checks passed
@tclose tclose deleted the nest_asyncio_dependency branch June 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged (label from auto)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants