-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nest_asyncio to install requires #501
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 84.27% 84.22% -0.06%
==========================================
Files 26 25 -1
Lines 5127 5123 -4
Branches 1447 1449 +2
==========================================
- Hits 4321 4315 -6
- Misses 800 802 +2
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
since this is required only for working with jupyter notebook, I would not add it to the basic requirements. However, we could perhaps add additional mode of installation "jupyter". Or checking if pydra is run inside the jupyter notebook and raise an error if |
Sounds good |
7621629
to
acda3e8
Compare
added "jupyter" install option to pyproject.toml as suggested |
acda3e8
to
23755a5
Compare
23755a5
to
e0d9a60
Compare
Acknowledgment
Types of changes
Summary
Adds nest-asyncio dependency to setup.cfg
Checklist
N/A