TEST: Use existing file to test BET shell task #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jun 16, 2020
Co-authored-by: Chris Markiewicz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 86.78% 86.77% -0.01%
==========================================
Files 19 20 +1
Lines 3156 3169 +13
Branches 837 841 +4
==========================================
+ Hits 2739 2750 +11
- Misses 260 261 +1
- Partials 157 158 +1
Continue to review full report at Codecov.
|
effigies
changed the title
effigies
approved these changes
Jun 17, 2020
satra
reviewed
Jun 17, 2020
|
|
||
| # separate command into exec + args | ||
| shelly = ShellCommandTask( | ||
| name="bet_task", executable="bet", in_file=in_file, input_spec=bet_input_spec | ||
| ) | ||
| assert shelly.inputs.executable == "bet" | ||
| assert shelly.cmdline == f"bet {in_file} {in_file}_brain" | ||
| # res = shelly(plugin="cf") | ||
| res = shelly(plugin="cf") |
There was a problem hiding this comment.
since we don't really want to run bet in pydra, should we just remove the actual execution?
There was a problem hiding this comment.
we actually don't run this test... see the decorator
|
Closed and reopened to trigger RTD build. Looks like it's working. |
|
Probably superseded by #425? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Checklist
(we are using
black: you canpip install pre-commit,run
pre-commit installin thepydradirectoryand
blackwill be run automatically with each commit)Acknowledgment