Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Replace deprecated pkgutil.find_loader with importlib.util.find_spec #3692

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

effigies
Copy link
Member

pkgutil.find_loader was deprecated in 3.12, will be removed in 3.14, and its replacement has been around since 3.4.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (fffc1c2) to head (52a6bf2).
Report is 83 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
- Coverage   70.85%   70.85%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       59118    59118              
  Branches     9803     8585    -1218     
==========================================
- Hits        41888    41887       -1     
- Misses      16061    16086      +25     
+ Partials     1169     1145      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 7139c7f into nipy:master Oct 16, 2024
19 checks passed
@effigies effigies deleted the rf/drop-pkgutil-find_loader branch October 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant