Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Text2Vest and Vest2Text interfaces #3447

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Apr 5, 2022

Summary

Create Text2Vest Interface to work directly with FILMGLS

References poldracklab/fitlins#114

List of changes proposed in this PR (pull-request)

  • add Text2Vest interface
  • add Vest2Text interface

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #3447 (62d8c46) into master (f8f7fb5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
+ Coverage   65.23%   65.24%   +0.01%     
==========================================
  Files         308      308              
  Lines       40625    40643      +18     
  Branches     5361     5361              
==========================================
+ Hits        26500    26518      +18     
  Misses      13049    13049              
  Partials     1076     1076              
Flag Coverage Δ
unittests 64.97% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/fsl/__init__.py 100.00% <ø> (ø)
nipype/interfaces/fsl/utils.py 64.46% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f7fb5...62d8c46. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Some minor suggestions.

@effigies effigies changed the title [ENH] add Text2Vest and Vest2Text interfaces [ENH] Add Text2Vest and Vest2Text interfaces Apr 7, 2022
@effigies effigies merged commit ecd5871 into nipy:master Apr 7, 2022
@effigies
Copy link
Member

effigies commented Apr 7, 2022

Thanks!

@jdkent jdkent deleted the enh/add_Text2Vest branch April 7, 2022 19:32
@effigies effigies added this to the 1.8.0 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants