-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename dipy move_streamlines
to transform_tracking_output
#3412
rename dipy move_streamlines
to transform_tracking_output
#3412
Conversation
a27e6f3
to
4d78dde
Compare
Codecov Report
@@ Coverage Diff @@
## master #3412 +/- ##
==========================================
- Coverage 65.21% 65.20% -0.02%
==========================================
Files 307 307
Lines 40507 40514 +7
Branches 5353 5353
==========================================
Hits 26417 26417
- Misses 13014 13021 +7
Partials 1076 1076
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will currently break in environments with old versions of dipy. What about falling back to the old version?
Would you mind fetching the latest changes from |
Co-authored-by: Chris Markiewicz <[email protected]>
e746a67
to
537457b
Compare
Thanks! |
My pleasure, thanks for the review! |
The dipy function
move_streamlines
was removed (https://dipy.org/documentation/1.1.1./api_changes/) and later added back under a different name (dipy/dipy@1046084).I haven't been able to test this yet due to an unrelated error (#3413).
Acknowledgment