Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dipy move_streamlines to transform_tracking_output #3412

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

koenhelwegen
Copy link
Contributor

@koenhelwegen koenhelwegen commented Nov 22, 2021

The dipy function move_streamlines was removed (https://dipy.org/documentation/1.1.1./api_changes/) and later added back under a different name (dipy/dipy@1046084).

I haven't been able to test this yet due to an unrelated error (#3413).

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@koenhelwegen koenhelwegen force-pushed the rename_dipy_move_streamlines branch from a27e6f3 to 4d78dde Compare November 22, 2021 22:32
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #3412 (537457b) into master (87d04ae) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3412      +/-   ##
==========================================
- Coverage   65.21%   65.20%   -0.02%     
==========================================
  Files         307      307              
  Lines       40507    40514       +7     
  Branches     5353     5353              
==========================================
  Hits        26417    26417              
- Misses      13014    13021       +7     
  Partials     1076     1076              
Flag Coverage Δ
unittests 64.93% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/mrtrix/convert.py 16.58% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d04ae...537457b. Read the comment docs.

@koenhelwegen koenhelwegen marked this pull request as ready for review November 22, 2021 23:18
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will currently break in environments with old versions of dipy. What about falling back to the old version?

@effigies effigies added this to the 1.7.1 milestone Mar 21, 2022
@effigies
Copy link
Member

Would you mind fetching the latest changes from master and rebasing on top of them or merging them into your branch?

@koenhelwegen koenhelwegen force-pushed the rename_dipy_move_streamlines branch from e746a67 to 537457b Compare March 21, 2022 14:47
@effigies
Copy link
Member

Thanks!

@effigies effigies merged commit 79132b5 into nipy:master Mar 21, 2022
@koenhelwegen
Copy link
Contributor Author

My pleasure, thanks for the review!

@koenhelwegen koenhelwegen deleted the rename_dipy_move_streamlines branch March 21, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants