Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] small edits to my previous pull request (PR #3394) due to bugs revealed when running within my nipype workflow #3396

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

fabioboh
Copy link
Contributor

Sorry for the confusion, these tiny changes avoid errors when using the interface within a nipype workflow.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #3396 (f4691be) into master (4575810) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3396   +/-   ##
=======================================
  Coverage   65.20%   65.20%           
=======================================
  Files         307      307           
  Lines       40457    40456    -1     
  Branches     5350     5350           
=======================================
  Hits        26379    26379           
+ Misses      13003    13002    -1     
  Partials     1075     1075           
Flag Coverage Δ
unittests 64.92% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/spm/preprocess.py 50.28% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4575810...f4691be. Read the comment docs.

@fabioboh
Copy link
Contributor Author

@effigies sorry but I think u need to have a look at this again

@fabioboh fabioboh changed the title small edits to my previous pull request (PR #3394) due to bugs revealed when running within my nipype workflow [FIX] small edits to my previous pull request (PR #3394) due to bugs revealed when running within my nipype workflow Oct 22, 2021
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@effigies effigies merged commit e497b0f into nipy:master Oct 25, 2021
@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants