Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Extension not extensions, after pybids v0.9 #3380

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

adelavega
Copy link
Contributor

Summary

Updates BIDSDataGrabber to reflect that extensions is a deprecated keyword, in favor of extension

Related issue: https://neurostars.org/t/issue-with-bidsdatagrabber-in-nipype-1-6-1/20243/3

Acknowledgment

  • [ X ] (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member

In retrospect, I wish we'd put this in PyBIDS rather than Nipype. This will break things for people with old versions of pybids, but it's obviously been broken for recent pybids.

@adelavega
Copy link
Contributor Author

Yeah. We could check the bids version and update based on that.

At least its easy for the user the over-ride the output query but for many users the error will be confusing

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #3380 (5d39ee0) into master (79e2fdf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3380   +/-   ##
=======================================
  Coverage   65.11%   65.11%           
=======================================
  Files         307      307           
  Lines       40373    40373           
  Branches     5326     5326           
=======================================
  Hits        26288    26288           
- Misses      13014    13018    +4     
+ Partials     1071     1067    -4     
Flag Coverage Δ
unittests 64.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/io.py 55.24% <ø> (ø)
nipype/algorithms/icc.py 57.53% <0.00%> (ø)
nipype/interfaces/fsl/utils.py 63.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e2fdf...5d39ee0. Read the comment docs.

@effigies
Copy link
Member

Yeah. I think this is fine. It would be good to start allowing interfaces to say "this requires pybids>=0.9". Right now they can only say "this requires this set of modules".

@effigies effigies merged commit 6a7837c into nipy:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants