-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add new flags to MRtrix/preprocess.py (DWI2Tensor, MRtransform) #3365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3365 +/- ##
==========================================
- Coverage 65.11% 64.83% -0.28%
==========================================
Files 307 307
Lines 40373 40366 -7
Branches 5326 5326
==========================================
- Hits 26288 26171 -117
- Misses 13014 13103 +89
- Partials 1071 1092 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello, I was wondering if anybody had the chance to look at this PR? :) I would like to create another PR with some extra flags for other tools and I would like to be sure that I followed correctly the guidelines. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Apologies for the slow response.
linear_transform = File( | ||
exists=True, | ||
argstr="-linear %s", | ||
position=1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to why all of these are position=1
, but I don't think it can hurt for another one to be.
The missing flags for DWI2Tensor and MRTransform interfaces were added in nipy/nipype#3365 and released in nipype 1.7.0. As a result, we do not need the local preprocess.py anymore.
Summary
This PR adds some new flags to MRtrix commands.
Please let me known if anything is missing.
List of changes proposed in this PR (pull-request)
-mask
flag fordwi2tensor
command-linear
flag formrtransform
commandAcknowledgment