[FIX] Changes the type of ConvertScalarImageToRGBInputSpec.mask_file from File to traits.Str #3364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am very new at making PR's so please let me know if I missed something formal about the process. I read the contributors guideline and have run the
make check-before-commit
andpre-commit
.Summary
The problem is described in depth in the linked issue.
The
mask_file
ofConvertScalarImageToRGBInputSpec
is an optional argument of typeFile
with a default value of"none"
andexists=True
.In some cases, this causes workflows to crash, as the nipype file validation sees that no file name
"none"
exists.#3363
Fixes
I propose changing the type to
traits.Str
, since themask_file
input to the commandline tool is either a string referencing an existing file, or the string"none"
. Looking at the inputspec, it seems a similar thing was done to another optional input:custom_color_map_file
.Acknowledgment