[FIX] BET incorrect output paths #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention - pytest fails 1 test unless the |
|
thanks @ZviBaratz - this looks reasonable to me. the failures appear to be unrelated to this PR (linked to nilearn tests). @oesteban - do you want to take this opportunity to fix the other issue about lengths of paths? |
|
With no activity regarding the other issue, I'm inclined to merge this. Any objections? |
|
none from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
cwdkeyword argument to_gen_fname()calls so that the returned output will reference the correct paths. This fixes #2916.