volterra_expansion_order documentation error #3213
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For fMRI model specification, in SPM, matlabbatch{n}.spm.stats.fmri_spec.volt = 2 corresponds to 'Model Interactions' and matlabbatch{n}.spm.stats.fmri_spec.volt =1 corresponds to 'Do not model Interactions'.
Currently, for the corresponding process in nipype, the Level1Design, we see volterra_expansion_order = traits.Enum(1, 2, field="volt", desc=("Model interactions - yes:1, no:2")).
I guess the correct description should rather be volterra_expansion_order = traits.Enum(1, 2, field="volt", desc=("Model interactions - no:1, yes:2"))
|
Seems reasonable. Is this consistent across SPM versions? |
|
I just checked for spm8 and it's the same thing. Without checking the previous versions (SPM5, SPM2, etc.) I think it's consistent across SPM versions. |
|
Sounds good. As it only changes the docs, it won't break scripts that work now, so I'm 👍 for merge. Apologies for the delay. Very busy time of year. |
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fMRI model specification, in SPM, matlabbatch{n}.spm.stats.fmri_spec.volt = 2 corresponds to 'Model Interactions' and matlabbatch{n}.spm.stats.fmri_spec.volt =1 corresponds to 'Do not model Interactions'.
Currently, for the corresponding process in nipype, the Level1Design, we see volterra_expansion_order = traits.Enum(1, 2, field="volt", desc=("Model interactions - yes:1, no:2")).
I guess the correct description should rather be volterra_expansion_order = traits.Enum(1, 2, field="volt", desc=("Model interactions - no:1, yes:2"))