-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Clean up tests #3195
TEST: Clean up tests #3195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3195 +/- ##
=========================================
- Coverage 65.07% 64.88% -0.2%
=========================================
Files 301 301
Lines 39624 39624
Branches 5247 5247
=========================================
- Hits 25786 25710 -76
- Misses 12771 12857 +86
+ Partials 1067 1057 -10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3195 +/- ##
==========================================
- Coverage 65.12% 64.99% -0.13%
==========================================
Files 301 301
Lines 39626 39609 -17
Branches 5247 5243 -4
==========================================
- Hits 25806 25745 -61
- Misses 12748 12809 +61
+ Partials 1072 1055 -17
Continue to review full report at Codecov.
|
@effigies - do you want to update using the new etelemetry >= 0.2.0? see here for an example. https://github.com/dandi/dandi-cli/blob/master/dandi/__init__.py#L44 |
Took a stab at it. To avoid replication in two places, just swapped out the guts in our old implementation. |
Discovered while working through #3154.
Acknowledgment