Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Clean up tests #3195

Merged
merged 9 commits into from
Mar 31, 2020
Merged

TEST: Clean up tests #3195

merged 9 commits into from
Mar 31, 2020

Conversation

effigies
Copy link
Member

Discovered while working through #3154.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies changed the title TEST: Skip PBS/OAR tests based on presence of submission programs TEST: Clean up tests Mar 25, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #3195 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3195     +/-   ##
=========================================
- Coverage   65.07%   64.88%   -0.2%     
=========================================
  Files         301      301             
  Lines       39624    39624             
  Branches     5247     5247             
=========================================
- Hits        25786    25710     -76     
- Misses      12771    12857     +86     
+ Partials     1067     1057     -10
Flag Coverage Δ
#unittests 64.88% <ø> (-0.2%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/plugins/pbsgraph.py 25% <0%> (-68.75%) ⬇️
nipype/pipeline/plugins/oar.py 18.6% <0%> (-34.89%) ⬇️
nipype/pipeline/plugins/base.py 59.72% <0%> (-4.39%) ⬇️
nipype/pipeline/plugins/tools.py 76.31% <0%> (-3.95%) ⬇️
nipype/pipeline/plugins/sgegraph.py 11.49% <0%> (-3.45%) ⬇️
nipype/pipeline/engine/base.py 84.48% <0%> (-1.73%) ⬇️
nipype/utils/logger.py 84.61% <0%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37fcfb...858d2dd. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #3195 into master will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3195      +/-   ##
==========================================
- Coverage   65.12%   64.99%   -0.13%     
==========================================
  Files         301      301              
  Lines       39626    39609      -17     
  Branches     5247     5243       -4     
==========================================
- Hits        25806    25745      -61     
- Misses      12748    12809      +61     
+ Partials     1072     1055      -17     
Flag Coverage Δ
#unittests 64.99% <0.00%> (-0.13%) ⬇️
Impacted Files Coverage Δ
nipype/__init__.py 46.80% <0.00%> (+12.43%) ⬆️
nipype/info.py 92.30% <ø> (ø)
nipype/pipeline/plugins/pbsgraph.py 25.00% <0.00%> (-68.75%) ⬇️
nipype/pipeline/plugins/oar.py 18.60% <0.00%> (-34.89%) ⬇️
nipype/pipeline/plugins/tools.py 76.31% <0.00%> (-3.95%) ⬇️
nipype/pipeline/plugins/sgegraph.py 11.49% <0.00%> (-3.45%) ⬇️
nipype/pipeline/plugins/base.py 60.00% <0.00%> (-2.47%) ⬇️
nipype/pipeline/engine/base.py 84.48% <0.00%> (-1.73%) ⬇️
nipype/utils/logger.py 84.61% <0.00%> (-1.54%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 69.30% <0.00%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f847fa7...e6ed8c6. Read the comment docs.

@effigies effigies mentioned this pull request Mar 29, 2020
@satra
Copy link
Member

satra commented Mar 30, 2020

@effigies - do you want to update using the new etelemetry >= 0.2.0?

see here for an example. https://github.com/dandi/dandi-cli/blob/master/dandi/__init__.py#L44

@effigies
Copy link
Member Author

Took a stab at it. To avoid replication in two places, just swapped out the guts in our old implementation.

@effigies effigies merged commit 6d160c3 into nipy:master Mar 31, 2020
@effigies effigies deleted the test/fixes branch March 31, 2020 13:27
@effigies effigies added this to the 1.5.0 milestone Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants