FIX: Use PackageInfo to get NiftyReg version #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Mar 24, 2020
| @@ -91,7 +99,7 @@ def _environ_update(self): | |||
| self.inputs.omp_core_val = Undefined | |||
|
|
|||
| def check_version(self): | |||
| _version = self.version_from_command() | |||
| _version = self.version | |||
There was a problem hiding this comment.
L106 assumes this is a bytes object. I think it's going to be a str?
There was a problem hiding this comment.
I think so. I got an error because it was a str so I removed the old L60: https://github.com/nipy/nipype/pull/3194/files/199dc2e3e1a6c5dd0f8f35b6a6497015325ee85f#diff-84c9861899b85298fccffbb72fe8fe9eL60.
I'll remove this one too.
Codecov Report
@@ Coverage Diff @@
## master #3194 +/- ##
==========================================
- Coverage 65.07% 65.07% -0.01%
==========================================
Files 301 301
Lines 39624 39627 +3
Branches 5247 5247
==========================================
+ Hits 25786 25787 +1
- Misses 12771 12775 +4
+ Partials 1067 1065 -2
Continue to review full report at Codecov.
|
effigies
approved these changes
Mar 24, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2615.
List of changes proposed in this PR (pull-request)
PackageInfoto get NiftyReg version as suggested in NiftyReg interface raises ValueError: invalid version number #2615.Acknowledgment