Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Pin pytest < 5.1.3 #3048

Closed
wants to merge 2 commits into from
Closed

Conversation

effigies
Copy link
Member

Summary

Seeing if pinning an old pytest resolves #3046.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #3048 into master will decrease coverage by 2.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
- Coverage   67.03%   64.07%   -2.96%     
==========================================
  Files         343      342       -1     
  Lines       44077    44030      -47     
  Branches     5551     5551              
==========================================
- Hits        29545    28211    -1334     
- Misses      13775    14669     +894     
- Partials      757     1150     +393
Flag Coverage Δ
#smoketests ?
#unittests 64.07% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 88.73% <ø> (-5.64%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-27.16%) ⬇️
nipype/interfaces/fsl/model.py 54.89% <0%> (-25.73%) ⬇️
nipype/interfaces/matlab.py 64.64% <0%> (-21.22%) ⬇️
nipype/interfaces/nipy/base.py 80% <0%> (-20%) ⬇️
nipype/workflows/fmri/fsl/estimate.py 47.88% <0%> (-16.91%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a0335...1081a41. Read the comment docs.

@effigies
Copy link
Member Author

So this appears to be fixing it, but having another look at it, I think the problem is that we're monkey-patching pathlib.Path, rather than providing a replacement, which means we're infecting other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_dcm2niix_dwi failing intermittently
1 participant