Remove versioning from loadpkl #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
approved these changes
Sep 6, 2019
|
the PR looks good. iirc (and that's asking a lot) the pickle issue that gave rise to this may have stemmed from trying to do things across python 2 and 3. i.e., run a workflow with python 2 and then rerun using the same cache with python 3. i don't think we have a multi-environment test for this. given our upcoming plans to ditch python 2, i'm not sure it's worth spending the effort at this point. |
|
Sounds reasonable. Thanks for this, @stilley2. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This flag is no longer need, so this PR removes it to simplify the code.
Fixes #3018
Acknowledgment