Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Specify correct stop criterion flag in PETPVC #3010

Merged
merged 2 commits into from
Aug 30, 2019
Merged

FIX: Specify correct stop criterion flag in PETPVC #3010

merged 2 commits into from
Aug 30, 2019

Conversation

bilgelm
Copy link
Contributor

@bilgelm bilgelm commented Aug 29, 2019

Summary

Fixes incorrect stopping criterion flag in the nipype wrapper for PETPVC.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member

LGTM. You'll want to run make specs and commit the updated nipype/interfaces/tests/test_auto_PETPVC.py file.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3010 into master will decrease coverage by 3.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3010      +/-   ##
==========================================
- Coverage    67.5%   64.16%   -3.34%     
==========================================
  Files         344      342       -2     
  Lines       44039    43984      -55     
  Branches     5554     5551       -3     
==========================================
- Hits        29727    28223    -1504     
- Misses      13560    14640    +1080     
- Partials      752     1121     +369
Flag Coverage Δ
#smoketests ?
#unittests 64.16% <ø> (-0.79%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/petpvc.py 54.71% <ø> (ø) ⬆️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 50% <0%> (-30.51%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-29.14%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23300e9...d18b159. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3010 into master will decrease coverage by 3.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3010      +/-   ##
==========================================
- Coverage    67.5%   64.16%   -3.34%     
==========================================
  Files         344      342       -2     
  Lines       44039    43984      -55     
  Branches     5554     5551       -3     
==========================================
- Hits        29727    28223    -1504     
- Misses      13560    14640    +1080     
- Partials      752     1121     +369
Flag Coverage Δ
#smoketests ?
#unittests 64.16% <ø> (-0.79%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/petpvc.py 54.71% <ø> (ø) ⬆️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 50% <0%> (-30.51%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-29.14%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23300e9...d18b159. Read the comment docs.

@effigies effigies changed the title FIX: stop criterion flag in PETPVC FIX: Specify correct stop criterion flag in PETPVC Aug 30, 2019
@effigies
Copy link
Member

Thanks for this!

@effigies effigies merged commit 9235266 into nipy:master Aug 30, 2019
@effigies effigies added this to the 1.2.2 milestone Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants