Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 3.2.0 #960

Merged
merged 4 commits into from
Oct 20, 2020
Merged

REL: 3.2.0 #960

merged 4 commits into from
Oct 20, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 16, 2020

Preparation for new feature release 3.2.0, targeting Monday, October 19.

There's room for fixes to get in first, but this is pretty overdue, so I'm not inclined to hold up for anything but critical bugs.

Open PRs that could probably finish off:

Please comment to flag any other issues that should be addressed.

Pre-release checklist

  • Review the open list of nibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
  • Review and update the release notes. Review and update the Changelog file.
  • Look at doc/source/index.rst and add any authors not yet acknowledged.
  • Use the opportunity to update the .mailmap file if there are any duplicate authors listed from git shortlog -nse.
  • Check the copyright year in doc/source/conf.py
  • Refresh the README.rst text from the LONG_DESCRIPTION in info.py by running make refresh-readme.
  • Check the dependencies listed in setup.cfg (e.g., install_requires, options.extras_require) and in doc/source/installation.rst and in requirements.txt and .travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
  • Make sure all tests pass (from the nibabel root directory): pytest --doctest-modules nibabel

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #960 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #960   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         101      101           
  Lines       12548    12548           
  Branches     2208     2208           
=======================================
  Hits        11531    11531           
  Misses        680      680           
  Partials      337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022832e...0469d5a. Read the comment docs.

@@ -315,6 +321,9 @@
"affiliation": "National Technical University of Athens, Greece",
"name": "Raktivan, Konstantinos"
},
{
"name": "Cal\u00e1bkov\u00e1, Mark\u00e9ta"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeggyCal I've added you to the Zenodo fragment, and you will be listed as an author in the Zenodo archive. Please let me know if you would like your name to be rendered otherwise, or if you have an affiliation and/or ORCID you would to use. I can also remove you if you'd rather not be listed as an author.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, I am honoured :) it is good as it is, thank you for messing up with unicode characters :)

@@ -282,16 +290,14 @@
"name": "Thirion, Bertrand",
"orcid": "0000-0001-5018-7895"
},
{
"name": "Gauthier, Carl"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krallznut I've added you to the Zenodo fragment, and you will be listed as an author in the Zenodo archive. Please let me know if you would like your name to be rendered otherwise, or if you have an affiliation and/or ORCID you would to use. I can also remove you if you'd rather not be listed as an author.

.zenodo.json Show resolved Hide resolved
@@ -167,6 +170,9 @@
"name": "Raamana, Pradeep Reddy",
"orcid": "0000-0003-4662-0558"
},
{
"name": "Klug, Julian"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulianKlug I've added you to the Zenodo fragment, and you will be listed as an author in the Zenodo archive. Please let me know if you would like your name to be rendered otherwise, or if you have an affiliation and/or ORCID you would to use. I can also remove you if you'd rather not be listed as an author.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late reply, below my affiliation details
ORCID: 0000-0002-4849-9811
affiliation: University of Geneva, Switzerland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants