FIX: Re-import externals/netcdf.py from scipy #821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation error currently appearing in the pre-release Travis build.
Targeting 2.5.x first, since some Python 2 compatibility was removed in 3.0-dev. Once this is fixed, I'll use this diff to port to 3.0-dev.
This ends up overwriting incremental fixes put in netcdf.py since the last sync (#179), most notably #493. @rdvincent If you have any files you'd like to test that aren't in our battery, I would appreciate it to make sure we're not breaking MINC1.
@matthew-brett Do you remember if we have any fixes/hacks where we specifically chose to diverge from scipy?