Skip to content

Conversation

@effigies
Copy link
Member

@effigies effigies commented Oct 6, 2019

Fixes deprecation error currently appearing in the pre-release Travis build.

Targeting 2.5.x first, since some Python 2 compatibility was removed in 3.0-dev. Once this is fixed, I'll use this diff to port to 3.0-dev.

This ends up overwriting incremental fixes put in netcdf.py since the last sync (#179), most notably #493. @rdvincent If you have any files you'd like to test that aren't in our battery, I would appreciate it to make sure we're not breaking MINC1.

@matthew-brett Do you remember if we have any fixes/hacks where we specifically chose to diverge from scipy?

@effigies effigies force-pushed the fix/numpy_deprecation branch from cc48b53 to 0b79a03 Compare October 6, 2019 14:22
@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #821 into maint/2.5.x will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/2.5.x     #821      +/-   ##
===============================================
- Coverage        89.99%   89.96%   -0.04%     
===============================================
  Files               95       95              
  Lines            12049    12049              
  Branches          2143     2143              
===============================================
- Hits             10844    10840       -4     
- Misses             857      864       +7     
+ Partials           348      345       -3
Impacted Files Coverage Δ
nibabel/openers.py 78.22% <0%> (-3.23%) ⬇️
nibabel/cmdline/parrec2nii.py 32.73% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38342e3...e15a0ca. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Oct 9, 2019

Tests seem to pass, and the coverage drops seem unrelated.

@effigies effigies merged commit 6b1fa66 into nipy:maint/2.5.x Oct 9, 2019
@effigies effigies deleted the fix/numpy_deprecation branch October 9, 2019 15:06
@effigies effigies modified the milestone: 3.0.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant