Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Expand CIFTI2 constants to use a synonym recoder #1256

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

effigies
Copy link
Member

For increased flexibility in the CIFTI2 axes API, this creates a set of synonyms for different CIFTI structures, mapping them onto the CIFTI_STRUCTURE_*.

Used for resolving synonyms in caret spec files in #1090, but mergeable on its own.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (590b226) 92.19% compared to head (20bffc3) 92.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          99       99           
  Lines       12456    12458    +2     
  Branches     2559     2560    +1     
=======================================
+ Hits        11484    11486    +2     
  Misses        648      648           
  Partials      324      324           
Files Changed Coverage Δ
nibabel/cifti2/cifti2.py 96.87% <100.00%> (+0.01%) ⬆️
nibabel/cifti2/cifti2_axes.py 98.51% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

@mgxd Would you mind having a look when you get a chance?

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things, otherwise looks good

nibabel/cifti2/cifti2_axes.py Show resolved Hide resolved
nibabel/cifti2/cifti2.py Outdated Show resolved Hide resolved
Co-authored-by: Mathias Goncalves <[email protected]>
@effigies effigies merged commit 4e7ad07 into nipy:master Sep 22, 2023
46 checks passed
@effigies effigies deleted the enh/cifti-constants branch September 22, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants