RF: refactor find_private_element #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
force-pushed
the
refactor-find-private
branch
from
d76f35b
to
b4f6cd3
Compare
Neater and more readable version of find_private_element, extend tests.
matthew-brett
force-pushed
the
refactor-find-private
branch
from
b4f6cd3
to
2157139
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
- Coverage 92.16% 92.16% -0.01%
==========================================
Files 98 98
Lines 12372 12364 -8
Branches 2543 2539 -4
==========================================
- Hits 11403 11395 -8
Misses 646 646
Partials 323 323
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
Apr 22, 2023
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
reviewed
Apr 22, 2023
Co-authored-by: Chris Markiewicz <[email protected]>
|
Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neater and more readable version of find_private_element, extend tests.