ENH: insert gradunwarp in bold workflow #3064
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3064 +/- ##
==========================================
- Coverage 49.29% 49.15% -0.14%
==========================================
Files 46 46
Lines 3593 3609 +16
==========================================
+ Hits 1771 1774 +3
- Misses 1822 1835 +13
☔ View full report in Codecov by Sentry. |
bpinsard
force-pushed
the
enh/gradunwarp
branch
from
ae42834 to
71845e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The goal of that PR is to integrate gradient unwarping to the BOLD preprocessing workflows (and to anat workflows through update of smriprep).
See #1550.
Relies on an updated version of the gradunwarp https://github.com/bpinsard/gradunwarp/tree/fix/mem_leaks.
Unwarping is applied on the initial ref (to use a single volume, it mainly takes into account the matrix size and affine rather than image content).
Warp-field is then passed to the bold_bold, bold_T1w, bold_std one-step resamplings.
Still a WIP: inserting gradient unwarping seems more challenging for BOLD than for anatomical images. I need to check how that integrates with sdcflows.
Necessary PRs:
nipreps/smriprep#355
nipreps/niworkflows#819
Documentation that should be reviewed
TODO: document the option to pass a gradient coeff file.