Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLD brain mask depicted in the ROIs reportlet does not correspond to the mask produced in the outputs #963

Closed
chrisgorgo opened this issue Feb 8, 2018 · 11 comments

Comments

@chrisgorgo
Copy link
Contributor

chrisgorgo commented Feb 8, 2018

Background: https://neurostars.org/t/fmriprep-1-0-6-2-issues-semi-random-brain-mask-failure-and-super-bright-areas-in-epi/1303/8

EDIT OE: (moved to new issue #982)

reportlet:
image

output mask:
image

@chrisgorgo
Copy link
Contributor Author

image
Seems like a 3dUnifize issue.

@chrisgorgo chrisgorgo changed the title BOLD brain mask depicted in ROIs reportled does not correspond to the mask produced in the outputs BOLD brain mask depicted in the ROIs reportlet does not correspond to the mask produced in the outputs Feb 8, 2018
@oesteban
Copy link
Member

oesteban commented Feb 8, 2018

I can confirm that this is also happening on our Phase 2 test base. I'm seeing this on ds000237/sub-0[3,6] and some edge case on sub-01.

@oesteban
Copy link
Member

oesteban commented Feb 8, 2018

@chrisgorgo
Copy link
Contributor Author

This might explain #964, but why this mask calculation fail is not visible in the ROIs reportlet?

@oesteban oesteban changed the title BOLD brain mask depicted in the ROIs reportlet does not correspond to the mask produced in the outputs Problematic BOLD references for some runs Feb 10, 2018
@chrisgorgo
Copy link
Contributor Author

I don't understand why you renamed this issue. I believe the original problem is still unresolved - the mask plotted in the report comes from a different estimation process than the one (two?) leading to _brainmask file in the outputs.

@oesteban oesteban changed the title Problematic BOLD references for some runs BOLD brain mask depicted in the ROIs reportlet does not correspond to the mask produced in the outputs Feb 14, 2018
@oesteban oesteban reopened this Feb 14, 2018
@oesteban
Copy link
Member

Sorry for the name change. I didn't understand the issue.

I've opened and closed #982, which is the issue that has been really addressed, restored the name and reopened this issue.

Also, I hope this message triggers a notification that makes all aware of these changes.

@chrisgorgo
Copy link
Contributor Author

No worries. Thanks for clarifying.

oesteban added a commit to oesteban/fmriprep that referenced this issue Feb 21, 2018
Now, the brain mask written out to the derivatives folder is the mask presented in the ROIs plot, but in MNI space.

Fixes (the MNI part of) nipreps#963.
@chrisgorgo
Copy link
Contributor Author

@oesteban #1002 mentioned that the fix was only for the MNI part - if the T1w requires fixing maybe we should reopen?

@oesteban
Copy link
Member

T1 was also fixed (a726ac4)

@chrisgorgo
Copy link
Contributor Author

chrisgorgo commented Feb 23, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants