Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading for clean compilation with openjdk-10 #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RockyRoad29
Copy link

When building using make, I had the following errors:

javac -source 1.5 -target 1.5 src/org/flatland/drip/Main.java src/org/flatland/drip/Switchable.java src/org/flatland/drip/SwitchableInputStream.java src/org/flatland/drip/SwitchableOutputStream.java -d classes/
warning: [options] bootstrap class path not set in conjunction with -source 5
error: Source option 5 is no longer supported. Use 6 or later.
error: Target option 1.5 is no longer supported. Use 1.6 or later.
make: *** [Makefile:13: classes/org/flatland/drip/Main.class] Error 2

If I replace them with 1.6, I got:

warning: [options] bootstrap class path not set in conjunction with -source 6
warning: [options] source value 6 is obsolete and will be removed in a future release
warning: [options] target value 1.6 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.

But we don't need them anymore AFAIK.
So I just dropped the options.
Then another warning came up:

src/drip_daemon.c:46:5: warning: implicit declaration of function ‘wait’ [-Wimplicit-function-declaration]

So I fixed that one according to
https://stackoverflow.com/questions/41884685/implicit-declaration-of-function-wait

Thank you devs !

@rwilliams rwilliams mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant