[Bugs] Rating Issues - Editing Issues #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rating set to 0 - There was a bug where if the rating was set to 0 and you had editing disabled, it would still allow editing. Fixed
Inconsistent Editing Function - The editing boolean inside the constructor wasn't setting the passed editing property, it was just always defaulting to true. Added an if statement for this in the constructor but there may be a better work around.
Editing Cursor - made a change so that if editing is disabled, we do not still have the pointer cursor that makes it look like we can edit the rating.
Great Component though!