Test modules built with changes in hive-hadoop2#1
Closed
nineinchnick wants to merge 349 commits intogibfrom
Closed
Test modules built with changes in hive-hadoop2#1nineinchnick wants to merge 349 commits intogibfrom
nineinchnick wants to merge 349 commits intogibfrom
Conversation
nineinchnick
force-pushed
the
gib
branch
3 times, most recently
from
b64f0ee to
7c928c1
Compare
nineinchnick
force-pushed
the
gib-test
branch
from
1b970a4 to
17afe38
Compare
nineinchnick
force-pushed
the
gib-test
branch
2 times, most recently
from
678d217 to
de829c8
Compare
nineinchnick
force-pushed
the
gib-test
branch
2 times, most recently
from
2e9f79c to
d25afc9
Compare
nineinchnick
force-pushed
the
gib-test
branch
from
d25afc9 to
16d3088
Compare
nineinchnick
force-pushed
the
gib-test
branch
from
16d3088 to
72122ab
Compare
nineinchnick
force-pushed
the
gib-test
branch
2 times, most recently
from
925b864 to
96a2a09
Compare
nineinchnick
force-pushed
the
gib-test
branch
from
96a2a09 to
ce66a4e
Compare
nineinchnick
force-pushed
the
gib-test
branch
2 times, most recently
from
fe954cc to
2f49a94
Compare
nineinchnick
force-pushed
the
gib
branch
2 times, most recently
from
f9a6f33 to
c7a5dc7
Compare
nineinchnick
force-pushed
the
gib-test
branch
from
2f49a94 to
285359e
Compare
MiguelWeezardo
force-pushed
the
gib
branch
2 times, most recently
from
75b2a5a to
6223f12
Compare
nineinchnick
force-pushed
the
gib
branch
2 times, most recently
from
191b3ed to
e6d7c24
Compare
Co-authored-by: Jack Klamer <jack.klamer@starburstdata.com> Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
Also, add ElasticsearchExternalQueryRunner to allow connecting to existing Elasticserver instances and define a constant for version 7 image name.
Directly create ColumnMetadata from Pinot FieldSpecs. Create PinotColumnHandles from ColumnMetadata in getColumnHandles. Previously a PinotColumnHandle was created which would be turned into ColumnMetadata and then converted back to PinotColumnHandle.
Remove unused methods. Remove unused parameters in methods. Fix warnings in TestDynamicTable.
`default` profile is not active when other profile is activated, and enforcer's and duplicate-finder's configuration should always apply.
- use `TrinoException` with `NOT_SUPPORTED` - use clear message
A regression test for row (struct) dereference pushdown within complex expressions where a field is dereferenced twice.
Before the change, projection pushdown with a column being referenced more than once could lead e.g. to an expression being returned from the connector, which did have an unbound variable.
costCalculatorWithEstimatedExchanges should be used before AddExchanges costCalculatorWithoutEstimatedExchanges should be used after AddExchanges
Extract adjustReplicatedJoinLocalExchangeCost so that it's easier to understand that local exchange cost for replicated joins has special treatment in cost calculators. Add TODO to remove adjustReplicatedJoinLocalExchangeCost once traits (e.g. data parallelism) are used to correctly estimate replicated join local exchange cost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only tests changes in trinodb#10323 and should not be merged.