Improve Logs UX #208
Merged
Improve Logs UX #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ctrox
commented
Feb 7, 2025
ctrox
commented
- Increases default look-back to match retention
- Add error messages when requested logs exceed retention
- Adds flags to get logs for absolute time ranges
- Add error message for when no logs have been found
thirdeyenick
reviewed
Feb 7, 2025
thirdeyenick
reviewed
Feb 7, 2025
ctrox
force-pushed
the
logs-ux
branch
2 times, most recently
from
cfc8fd4 to
516e075
Compare
The logs retention is 30 days so we should always try to look back further to improve the user experience. This does not impact query performance if there are recent logs found. Going back 20+ days takes a few seconds but it's still acceptable.
This adds two new flags that when set, override the since parameter to only show logs in this absolute time frame. This can be useful when looking for logs beyond the (server-side) line limit of 5000 lines.
To achieve this the log output has been wrapped with a new interface that needs to implement LineCount(). This is also useful in the tests where we previously counted the lines in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.