Allow newer versions of Faraday #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! Is there a reason why you limit the version to |
|
v 0.13 (not released yet) shouldn't introduce breaking changes, but better be safe than sorry. I can edit that to |
|
No, then it's probably all right. As [per their current CONTRIBUTING.md], they do not yet fully honor SemVer, because they haven't yet reached |
cimnine
approved these changes
May 8, 2017
|
A new version has been released, v0.1.0. Thanks again! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current faraday (0.9.x) is locked to a version more than 1 year old, newest version is 0.12.x.
From their changelog, 0.10 and up introduce only one breaking change: removal of ruby 1.8.x support. Seems like cloudflair is not supporting that version anyway, so updating the faraday version should not break anything.