Mempool txn prioritization #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
viquezclaudio
commented
Jul 5, 2022
•
viquezclaudio
commented
- Introduces some priorities (low, medium, high) to transactions when they are added into the mempool.
- Exposes this functionality via RPC
- The unpark transaction is included into the mempool with high priority
Codecov Report
@@ Coverage Diff @@
## albatross #920 +/- ##
==========================================
Coverage 64.27% 64.27%
==========================================
Files 359 359
Lines 42264 42306 +42
==========================================
+ Hits 27167 27194 +27
- Misses 15097 15112 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
viquezclaudio
force-pushed
the
viquezcl/mempool_txn_priority
branch
from
ca7297e to
317458b
Compare
viquezclaudio
force-pushed
the
viquezcl/mempool_txn_priority
branch
from
317458b to
af7660b
Compare
nibhar
approved these changes
Jul 14, 2022
mempool/src/mempool.rs
Outdated
Comment on lines
676
to
683
| if let Some(priority) = tx_priority { | ||
| RwLockUpgradableReadGuard::upgrade(mempool_state_lock) | ||
| .put(&transaction, priority); | ||
| } else { | ||
| //If the priority is not provided we default to medium | ||
| RwLockUpgradableReadGuard::upgrade(mempool_state_lock) | ||
| .put(&transaction, TxPriority::MediumPriority); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let Some(priority) = tx_priority { | |
| RwLockUpgradableReadGuard::upgrade(mempool_state_lock) | |
| .put(&transaction, priority); | |
| } else { | |
| //If the priority is not provided we default to medium | |
| RwLockUpgradableReadGuard::upgrade(mempool_state_lock) | |
| .put(&transaction, TxPriority::MediumPriority); | |
| } | |
| RwLockUpgradableReadGuard::upgrade(mempool_state_lock) | |
| .put(&transaction, tx_priority.unwrap_or(TxPriority::MediumPriority)); |
| @@ -520,7 +521,7 @@ impl Mempool { | |||
| let pending_balance = tx.total_value() + sender_total; | |||
|
|
|||
| if pending_balance <= sender_balance { | |||
| mempool_state.put(tx); | |||
| mempool_state.put(tx, TxPriority::MediumPriority); | |||
There was a problem hiding this comment.
All reverted transactions are added as MediumPriority. The fact they might have been added as HighPriority is lost of course, but potentially we could still add unpark transactions as HighPriority.
This commit allows one to specify a transaction priority when txns are being addded to the mempool, such that txns with higher priority are returned first. This is exposed to the RPC interface It is also used to prioritize our own unpark transactions
viquezclaudio
force-pushed
the
viquezcl/mempool_txn_priority
branch
from
af7660b to
cf35d46
Compare
|
When querying mempool state, e.g. via RPC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.