Changing add stake operation #3196
Draft
+536
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ii-cruz
force-pushed
the
iicruz/fix-staker-dos
branch
from
e62eccb to
94256d9
Compare
paberr
approved these changes
Mar 30, 2025
| // If we are delegating to a validator, we need to update it. | ||
| if let Some(validator_address) = &staker.delegation { | ||
| // Check that the delegation is still valid, i.e. the validator hasn't been deleted. | ||
| store.expect_validator(validator_address)?; |
There was a problem hiding this comment.
There might be a problem with the ordering. We usually want to do changes only after all potentially failing conditions are checked.
In practice, I don't think it is a problem, as all previous changes are in the staker and that one needs to be put explicitly back.
|
When |
|
It doesn't reset it. Also, while discussing with @ii-cruz , one thing that is missing is a version gate for the upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
add_stakeoperation. Add stake transactions have an intrinsic check for itsvalue => min_stakeand thus are rejected before they can break the invariant.add_stakeassumes that the staker wants to have auto-staking as long as there is active stake. Once no active stake exists, the funds are added to whatever is the biggest balance between inactive and retired.Pull request checklist
clippyandrustfmtwarnings.