Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use subprocess.run(..., shell=True) #3080

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

hrxi
Copy link
Contributor

@hrxi hrxi commented Nov 16, 2024

This makes automated vulnerability scanners happy.

@hrxi hrxi force-pushed the hrxi/minor_fixes75 branch 2 times, most recently from 520da41 to d2631c7 Compare November 20, 2024 21:04
Copy link
Member

@paberr paberr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrxi hrxi force-pushed the hrxi/minor_fixes75 branch 3 times, most recently from 0e00c1c to 232ee30 Compare November 26, 2024 16:06
hrxi added 8 commits November 26, 2024 18:21

Verified

This commit was signed with the committer’s verified signature.
This makes automated vulnerability scanners happy.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Its only being used with `incoming` set to `true` since
444121a, because that commit moved the
proofs from the transaction proof to the recipient data.
`directories::UserDirs` scanned more of the system to find Documents
etc. folders.
@hrxi hrxi force-pushed the hrxi/minor_fixes75 branch from 232ee30 to e2410fb Compare November 26, 2024 17:21
@hrxi hrxi merged commit e2410fb into albatross Nov 26, 2024
8 checks passed
@hrxi hrxi deleted the hrxi/minor_fixes75 branch November 26, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants