Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #2899

Merged
merged 1 commit into from
Sep 16, 2024
Merged

chore: fix some comments #2899

merged 1 commit into from
Sep 16, 2024

Conversation

zhedazijingang
Copy link
Contributor

What's in this pull request?

fix some comments

...

This fixes #___.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

Copy link
Member

@Eligioo Eligioo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing those

@Eligioo
Copy link
Member

Eligioo commented Sep 12, 2024

@zhedazijingang can you make sure the commit is signed?

@zhedazijingang
Copy link
Contributor Author

@zhedazijingang can you make sure the commit is signed?

Of course. Signed

Signed-off-by: zhedazijingang <[email protected]>
@hrxi
Copy link
Member

hrxi commented Sep 16, 2024

Rebased for merging.

@hrxi hrxi merged commit f7fd35a into nimiq:albatross Sep 16, 2024
6 checks passed
@hrxi
Copy link
Member

hrxi commented Sep 16, 2024

Thanks!

@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants