Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split code cov in 3 tasks #2762

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

ii-cruz
Copy link
Member

@ii-cruz ii-cruz commented Jul 22, 2024

What's in this pull request?

Code coverage runs out of disk.
This PR splits code cov into 3 jobs/tasks instead of 2, it should speed up code cov and reduce the amount of disk space needed per job.

Pull request checklist

  • [] All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@ii-cruz ii-cruz added bug Something isn't working github_actions Pull requests that update Github_actions code labels Jul 22, 2024
@ii-cruz ii-cruz added this to the Nimiq PoS Mainnet milestone Jul 22, 2024
@ii-cruz ii-cruz self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.33%. Comparing base (16a99b7) to head (69c305b).
Report is 28 commits behind head on albatross.

Additional details and impacted files
@@              Coverage Diff              @@
##           albatross    #2762      +/-   ##
=============================================
+ Coverage      68.25%   68.33%   +0.08%     
=============================================
  Files            411      410       -1     
  Lines          57077    57117      +40     
=============================================
+ Hits           38957    39030      +73     
+ Misses         18120    18087      -33     
Flag Coverage Δ
unittests 68.33% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ii-cruz ii-cruz force-pushed the iicruz/fix-code-cov-out-of-storage branch 7 times, most recently from c44c38b to 9f1c11f Compare July 22, 2024 13:26
@ii-cruz ii-cruz requested a review from jsdanielh July 22, 2024 13:28
@ii-cruz ii-cruz marked this pull request as ready for review July 22, 2024 13:28
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Outdated Show resolved Hide resolved
@ii-cruz ii-cruz force-pushed the iicruz/fix-code-cov-out-of-storage branch from 9f1c11f to 69c305b Compare July 22, 2024 18:03
@jsdanielh jsdanielh force-pushed the iicruz/fix-code-cov-out-of-storage branch from 69c305b to 5aeb490 Compare July 22, 2024 23:54
@jsdanielh jsdanielh merged commit 5aeb490 into albatross Jul 23, 2024
7 checks passed
@jsdanielh jsdanielh deleted the iicruz/fix-code-cov-out-of-storage branch July 23, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants