Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool to measure history store performance #2617

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

viquezclaudio
Copy link
Member

@viquezclaudio viquezclaudio commented Jun 14, 2024

History store:
cargo run --release --bin nimiq-performance-history-store -- --batches 10 --tpb 700

Light History store:
cargo run --release --bin nimiq-performance-history-store -- --batches 100 --tpb 700 --light

Rounds operation:
For example, 700 batches in total in 10 rounds (70 batches per round)
cargo run --release --bin nimiq-performance-history-store -- --batches 700 --rounds 10 --tpb 100

@viquezclaudio viquezclaudio added the WIP This pull request is still work in progress label Jun 14, 2024
@viquezclaudio viquezclaudio force-pushed the viquezcl/history_store_perf branch 4 times, most recently from 9e22be2 to 9987176 Compare June 17, 2024 15:03
Comment on lines 174 to 201
history_store_performance(history_store, env, args.tpb, args.batches, rounds, db_file);

exit(0);
Copy link
Member

@sisou sisou Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete the temp database file after the benchmark finishes:

Suggested change
history_store_performance(history_store, env, args.tpb, args.batches, rounds, db_file);
exit(0);
history_store_performance(history_store, env, args.tpb, args.batches, rounds, db_file);
let _ = fs::remove_dir_all(temp_dir);
exit(0);

@viquezclaudio viquezclaudio force-pushed the viquezcl/history_store_perf branch 2 times, most recently from 2034be4 to fcc021e Compare June 17, 2024 15:46
@viquezclaudio viquezclaudio removed the WIP This pull request is still work in progress label Jun 17, 2024
Copy link
Member

@Eligioo Eligioo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it has some Clippy warnings that should be easy to resolve.

@paberr paberr force-pushed the viquezcl/history_store_perf branch from 4887cee to e1fd867 Compare June 20, 2024 14:35
@viquezclaudio viquezclaudio force-pushed the viquezcl/history_store_perf branch 2 times, most recently from 35b1de2 to b9dd23e Compare June 24, 2024 15:27
Copy link
Member

@paberr paberr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a version of this tool on pb/history_store_perf, which will be compatible with the changes in PR #2692 . I suggest merging the history store changes first and I can then cherry pick the necessary commits over to this PR.

@paberr paberr force-pushed the viquezcl/history_store_perf branch from b9dd23e to e08291d Compare July 9, 2024 08:22
@paberr
Copy link
Member

paberr commented Jul 9, 2024

I have a version of this tool on pb/history_store_perf, which will be compatible with the changes in PR #2692 . I suggest merging the history store changes first and I can then cherry pick the necessary commits over to this PR.

Pushed the cherry-picked commits.

@jsdanielh jsdanielh force-pushed the viquezcl/history_store_perf branch from e08291d to f3acfc7 Compare July 10, 2024 21:28
@jsdanielh jsdanielh force-pushed the viquezcl/history_store_perf branch from 90b3f90 to 634c39b Compare July 11, 2024 16:09
@jsdanielh jsdanielh merged commit 634c39b into albatross Jul 11, 2024
7 checks passed
@jsdanielh jsdanielh deleted the viquezcl/history_store_perf branch July 11, 2024 16:49
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants