-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool to measure history store performance #2617
Conversation
9e22be2
to
9987176
Compare
history_store_performance(history_store, env, args.tpb, args.batches, rounds, db_file); | ||
|
||
exit(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete the temp database file after the benchmark finishes:
history_store_performance(history_store, env, args.tpb, args.batches, rounds, db_file); | |
exit(0); | |
history_store_performance(history_store, env, args.tpb, args.batches, rounds, db_file); | |
let _ = fs::remove_dir_all(temp_dir); | |
exit(0); |
2034be4
to
fcc021e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it has some Clippy warnings that should be easy to resolve.
173835b
to
35b1de2
Compare
4887cee
to
e1fd867
Compare
35b1de2
to
b9dd23e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a version of this tool on pb/history_store_perf
, which will be compatible with the changes in PR #2692 . I suggest merging the history store changes first and I can then cherry pick the necessary commits over to this PR.
b9dd23e
to
e08291d
Compare
Pushed the cherry-picked commits. |
e08291d
to
f3acfc7
Compare
Ability to support a X number of rounds operations, where each round commits Y number of batches to the DB
Fix clippy warnings in the history store performance binary.
90b3f90
to
634c39b
Compare
History store:
cargo run --release --bin nimiq-performance-history-store -- --batches 10 --tpb 700
Light History store:
cargo run --release --bin nimiq-performance-history-store -- --batches 100 --tpb 700 --light
Rounds operation:
For example, 700 batches in total in 10 rounds (70 batches per round)
cargo run --release --bin nimiq-performance-history-store -- --batches 700 --rounds 10 --tpb 100